Repository navigation
Make CursorAdapter.DataSource accept non-string values in XSharp.VFP.UI - #2169
Merged
RobertvanderHulst merged 1 commit intoNov 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
CursorAdapter.DataSourceinXSharp.VFP.UIwas declaredAS STRING. A VFP handle assigned as a number (CursorAdapter.DataSource = 1) therefore fails to compile.XSharp.VFPandXSharp.Datadeclare the same property asObject, so the UI class was the outlier.Change
src/Runtime/XSharp.VFP.UI/Generated/CursorAdapter.generated.prg:PROPERTY DataSource AS STRING AUTObecomesAS OBJECT AUTO.src/Tests/CursorAdapterTests/CheckDataSourceType.py: the regression check asserts the declared type isOBJECT.The only in-repo caller,
src/Tests/CursorAdapterTests/Program.prg, assigns a handle and reads the value back, so the type change does not affect it.Testing
python src/Tests/CursorAdapterTests/CheckDataSourceType.pypasses on the fixed file (PASS: DataSource is declared AS OBJECT).FAIL: DataSource must be declared AS OBJECT, found AS STRING).Not verified: the compiler and
XSharp.VFP.UIwere not built, so the build error is not reproduced here. The check is text-based and does not compile anything.Open item
Generated/CursorAdapter.generated.prgis produced by a generator that is not in this repository. Regenerating the file will revert this change unless the generator is updated too.Regression test: fails on base (/DataSource must be declared AS OBJECT/), passes on fix (
python src/Tests/CursorAdapterTests/CheckDataSourceType.py)Fixes #1558