Skip to content

REST API: Allow null template origin - #13294

Open
sunilwordpress wants to merge 2 commits into
WordPress:trunkfrom
sunilwordpress:fix/64168-template-parts-schema
Open

REST API: Allow null template origin#13294
sunilwordpress wants to merge 2 commits into
WordPress:trunkfrom
sunilwordpress:fix/64168-template-parts-schema

Conversation

@sunilwordpress

@sunilwordpress sunilwordpress commented Aug 27, 2026

Copy link
Copy Markdown

Description

The REST API schema for the origin property of the wp/v2/template-parts endpoint currently declares the value as a string.

However, WP_Block_Template::origin can also return null, so the schema does not accurately describe the actual REST API response.

This change updates the origin schema to accept both string and null values.

Trac ticket: https://core.trac.wordpress.org/ticket/64168

Testing

  • PHPUnit tests for WP_REST_Templates_Controller pass.
  • Result: 49 tests, 143 assertions.

Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Luna
Used for: Reviewing the proposed change, discussing the implementation and test approach, and troubleshooting the Git/GitHub contribution workflow. The final code change was reviewed and tested by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sunwpdeveloper.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant