Skip to content

Block supports: Add the has-fit-text class when rendering fit text on the server - #13287

Closed
t-hamano wants to merge 6 commits into
WordPress:trunkfrom
t-hamano:65973-fix-text-server-side
Closed

Block supports: Add the has-fit-text class when rendering fit text on the server#13287
t-hamano wants to merge 6 commits into
WordPress:trunkfrom
t-hamano:65973-fix-text-server-side

Conversation

@t-hamano

@t-hamano t-hamano commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Applies the PHP portion of WordPress/gutenberg#82074 to Core.

Trac ticket: https://core.trac.wordpress.org/ticket/65973

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Porting the change from the linked Gutenberg PR and drafting the unit tests; reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

… the server.

Co-Authored-By: Claude <noreply@anthropic.com>
@t-hamano
t-hamano marked this pull request as ready for review August 27, 2026 07:36
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

…ort tests.

Co-Authored-By: Claude <noreply@anthropic.com>

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some improved typing in tests.

Comment thread tests/phpunit/tests/block-supports/typography.php Outdated
Comment thread tests/phpunit/tests/block-supports/typography.php Outdated
Comment thread tests/phpunit/tests/block-supports/typography.php Outdated
@t-hamano

Copy link
Copy Markdown
Contributor Author

@westonruter Thanks for the review!

Comment thread src/wp-includes/block-supports/typography.php Outdated
hubot pushed a commit to nacin/wp-develop that referenced this pull request Aug 28, 2026
Inject the `has-fit-text` class into the block wrapper during server-side rendering, so that fit text also takes effect on dynamically rendered blocks.

Developed in: WordPress/wordpress-develop#13287

Props westonruter, wildworks.
Fixes #65973.

git-svn-id: https://develop.svn.wordpress.org/trunk@63382 602fd350-edb4-49c9-b593-d223f7449a82
@t-hamano

Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano closed this Aug 28, 2026
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 28, 2026
Inject the `has-fit-text` class into the block wrapper during server-side rendering, so that fit text also takes effect on dynamically rendered blocks.

Developed in: WordPress/wordpress-develop#13287

Props westonruter, wildworks.
Fixes #65973.
Built from https://develop.svn.wordpress.org/trunk@63382


git-svn-id: http://core.svn.wordpress.org/trunk@62575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants