Name each remote workload's in-page suite after the workload - #586
Open
canova wants to merge 2 commits into
Open
Name each remote workload's in-page suite after the workload#586canova wants to merge 2 commits into
canova wants to merge 2 commits into
Conversation
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I noticed this while I was looking at some profiles with performance.mark/measure markers. I could see some `suite-default` which looks odd compared to what we usually have in other workloads with proper names (like `suite-Responsive-Design` etc.). It looks like this was becuse we were passing `"default"` as a name paramater to the BenchmarkSuite constructor. This patch adds proper names for these workfloads so they can get better names instead of `suite-default` in their user timing entries. See the performance.mark/measure calls here: https://github.com/WebKit/Speedometer/blob/9304efe45ef1d982c5eb9ac14f6353b264d56940/resources/shared/benchmark.mjs#L56-L78
Currently one dist serves TodoMVC-WebComponents-IndexedDB and TodoMVC-WebComponents-DexieJS, and they are split only by the storageType URL param, but looks like both named their suite "indexeddb". Because of this, every mark and measure collided, down to the step level, so a user timing entry couldn't tell them apart.
canova
force-pushed
the
remote-workload-names
branch
from
August 24, 2026 18:52
aeaab2f to
656fbc5
Compare
Author
|
I also saw that we had 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while I was looking at some profiles with performance.mark/measure markers. I could see some
suite-defaultwhich looks odd compared to what we usually have in other workloads with proper names (likesuite-Responsive-Designetc.).It looks like this was becuse we were passing
"default"as a name paramater to the BenchmarkSuite constructor. This patch adds proper names for these workfloads so they can get better names instead ofsuite-defaultin their user timing entries.See the performance.mark/measure calls here:
Speedometer/resources/shared/benchmark.mjs
Lines 56 to 78 in 9304efe