Skip to content

FE/Qt: Place the full-screen mini-toolbar on the machine window's monitor #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dr1fter wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

FE/Qt: Place the full-screen mini-toolbar on the machine window's monitor #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/VBox/Frontends/VirtualBox/src/widgets/UIMiniToolBar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,10 @@ void UIMiniToolBar::sltAdjust()

/* Get corresponding host-screen: */
const int iHostScreenCount = UIDesktopWidgetWatchdog::screenCount();
int iHostScreen = UIDesktopWidgetWatchdog::screenNumber(m_pParent);
/* Resolve the host-screen from the parent's assigned geometry rather than from
* its native QWindow association, which can still lag behind the geometry set by
* UIMachineWindowFullscreen::placeOnScreen() during a full-screen transition: */
int iHostScreen = UIDesktopWidgetWatchdog::screenNumber(m_pParent->geometry().center());
// WORKAROUND:
// When switching host-screen count, especially in complex cases where RDP client is "replacing" host-screen(s) with own virtual-screen(s),
// Qt could behave quite arbitrary and laggy, and due to racing there could be a situation when QDesktopWidget::screenNumber() returns -1
Expand Down