Skip to content

Label oauth2 auth methods so multiple templates stay distinguishable - #1756

Merged
RhysSullivan merged 1 commit into
mainfrom
oauth-method-labels
Aug 26, 2026
Merged

Label oauth2 auth methods so multiple templates stay distinguishable#1756
RhysSullivan merged 1 commit into
mainfrom
oauth-method-labels

Conversation

@RhysSullivan

@RhysSullivan RhysSullivan commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

An integration that declares several oauth2 auth templates (Microsoft Graph: delegated + client credentials) rendered them as identical "OAuth2" tabs in the add-connection dialog.

Before After
before: two identical OAuth2 tabs after: OAuth2 (user) and OAuth2 (app-only) tabs
  • Add an optional display label to OAuthAuthentication and carry it through the stored config, add-spec wire schemas, the HTTP payload schema, and the auth-template editor round-trip.
  • Microsoft Graph templates now declare "OAuth2 (user)" (delegated) and "OAuth2 (app-only)" (client credentials).
  • Spec-derived detection labels oauth2 methods from their preview presets only when a spec yields more than one, so lone methods keep the plain "OAuth2" tab.
  • Both auth-method projections (catalog descriptors and client config) fall back to "OAuth2" when no label is stored, so existing integrations are unchanged. Re-adding an integration picks up the labels.

Verified on a local dev instance: adding the Outlook Mail preset stores labelled templates and the add-connection dialog shows the two distinct tabs. Unit suites for openapi/react/core-sdk pass; auth-methods-ui e2e scenario passes on selfhost.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 66ba1ad Commit Preview URL

Branch Preview URL
Aug 26 2026, 07:30 AM

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 66ba1ad Aug 26 2026, 07:31 AM

@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1756

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1756

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1756

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1756

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1756

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1756

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1756

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1756

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1756

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1756

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1756

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1756

executor

npm i https://pkg.pr.new/executor@1756

commit: 66ba1ad

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 26, 2026 18:56
@RhysSullivan
RhysSullivan merged commit a788874 into main Aug 26, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant