fix(oauth): honor discovered CIMD support - #1732
Open
aryasaatvik wants to merge 2 commits into
Open
Conversation
aryasaatvik
marked this pull request as ready for review
August 25, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefer Client ID Metadata Documents when OAuth discovery advertises CIMD support, including servers that also expose a dynamic-registration endpoint. This keeps automatic MCP OAuth on the server-advertised path instead of incorrectly asking the user to register an app.
Flow
The probe handoff uses the SDK canonical
OAuthProbeResult, so new discovery capabilities cannot be dropped by a duplicated UI-only type.Validation
bunx vitest run src/components/add-account-modal.test.ts(45 tests)bun run typecheckbunx oxlint -c ../../.oxlintrc.jsonc src/components/add-account-modal.tsx src/components/add-account-modal.test.ts --deny-warnings./node_modules/.bin/oxlint -c .oxlintrc.jsonc packages/core/sdk/src/testing/oauth-test-server.ts e2e/selfhost/mcp-oauth-cimd-connect.test.ts --deny-warnings./node_modules/.bin/oxfmt --check packages/core/sdk/src/testing/oauth-test-server.ts e2e/selfhost/mcp-oauth-cimd-connect.test.ts./node_modules/.bin/vitest run --project selfhost selfhost/mcp-oauth-cimd-connect.test.ts— browser E2E passed with recording and trace