fix(ui5-search,ui5-shellbar-search): close the search popover on user request - #14001
Open
nikoletavnv wants to merge 2 commits into
Open
fix(ui5-search,ui5-shellbar-search): close the search popover on user request#14001nikoletavnv wants to merge 2 commits into
nikoletavnv wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://pr-14001--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the shellbar search stayed open and could not be closed when changing the public property open to false. With this change, the priority of the open state goes to the applications. The search component will still be able to modify the open state of the control, but in case the user decides something else, the external property change will have priority.