refactor(cli): Consolidate UI5 data dir resolution into dataDir module - #1555
Open
matz3 wants to merge 1 commit into
Open
refactor(cli): Consolidate UI5 data dir resolution into dataDir module#1555matz3 wants to merge 1 commit into
matz3 wants to merge 1 commit into
Conversation
Introduce lib/dataDir.js exposing getUi5DataDir, getUi5DataDirOrDefault and a formatPath helper that shortens home-directory paths to ~ for display. This consolidates the previously duplicated ui5DataDir resolution logic that framework utils and the cache command each carried their own copy of. The cache command now resolves the data dir via getUi5DataDirOrDefault and lazily imports FrameworkCache and CacheManager, so the modules are not loaded on every CLI invocation. Displayed cache paths use formatPath. This only consolidates resolution within the cli package; a general, cross-package cleanup remains tracked in PR #1456.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce lib/dataDir.js exposing getUi5DataDir, getUi5DataDirOrDefault and a formatPath helper that shortens home-directory paths to ~ for display. This consolidates the previously duplicated ui5DataDir resolution logic that framework utils and the cache command each carried their own copy of.
The cache command now resolves the data dir via getUi5DataDirOrDefault and lazily imports FrameworkCache and CacheManager, so the modules are not loaded on every CLI invocation. Displayed cache paths use formatPath.
This only consolidates resolution within the cli package; a general, cross-package cleanup remains tracked in PR #1456.