Skip to content

fix: publish comment collapse and seek preview tuning in 1.8.0-beta.8 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Priveetee merged 3 commits into from
Sep 10, 2026
Merged

fix: publish comment collapse and seek preview tuning in 1.8.0-beta.8 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
868b2df
feat: collapse expanded comments with show less
Priveetee Sep 10, 2026
249cc4c
perf: select lightweight storyboard seek previews
Priveetee Sep 10, 2026
451470a
build: publish mobile beta 1.8.0-beta.8
Priveetee Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ android {
applicationId = "dev.typetype.android"
minSdk = 23
targetSdk = 37
versionCode = 10807
versionName = "1.8.0-beta.7"
versionCode = 10808
versionName = "1.8.0-beta.8"
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
resValue("string", "app_name", "TypeType")
}
Expand Down
3 changes: 2 additions & 1 deletion app/src/androidTest/java/dev/typetype/android/feature/player/components/CommentBodyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class CommentBodyTest {
}

composeRule.onNodeWithText("Read more").assertExists().performClick()
composeRule.onNodeWithText("Long comment starts here$suffix").assertExists()
composeRule.onNodeWithText("Show less").assertExists().performClick()
composeRule.onNodeWithText("Read more").assertExists()
}
}
8 changes: 7 additions & 1 deletion app/src/main/java/dev/typetype/android/data/stream/StreamRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ internal class StreamRepositoryImpl @Inject constructor(
},
storyboard = previewFrames
.mapNotNull { it.toDomainStoryboard() }
.maxByOrNull { it.frameWidth },
.let(::selectStoryboard),
startPositionMillis = startPosition * 1000L,
sponsorBlockSegments = sponsorBlockSegments.mapNotNull {
it.toDomainSponsorBlockSegment(duration)
Expand All @@ -207,6 +207,11 @@ internal class StreamRepositoryImpl @Inject constructor(
.maxByOrNull { it.height }
?.url

private fun selectStoryboard(storyboards: List<StreamStoryboard>): StreamStoryboard? =
storyboards.filter { it.frameWidth >= TARGET_STORYBOARD_FRAME_WIDTH }
.minByOrNull { it.frameWidth }
?: storyboards.maxByOrNull { it.frameWidth }

private fun PreviewFrameItem.toDomainStoryboard(): StreamStoryboard? =
StreamStoryboard(
urls = urls.filter(String::isNotBlank),
Expand Down Expand Up @@ -289,6 +294,7 @@ internal suspend fun <T> cancellableStreamResult(
}

private const val SABR_DELIVERY_METHOD = "sabr"
private const val TARGET_STORYBOARD_FRAME_WIDTH = 160

private class SabrContractException :
IllegalStateException("The server returned no playable SABR contract"),
Expand Down
10 changes: 7 additions & 3 deletions app/src/main/java/dev/typetype/android/feature/player/components/CommentListItems.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,17 @@ private fun ExpandableCommentText(
maxLines = if (expanded) Int.MAX_VALUE else COMMENT_COLLAPSE_LINE_LIMIT,
overflow = if (expanded) TextOverflow.Clip else TextOverflow.Ellipsis,
)
if (needsTruncation && !expanded) {
if (needsTruncation) {
TextButton(
onClick = { expanded = true },
onClick = { expanded = !expanded },
contentPadding = PaddingValues(horizontal = 4.dp),
modifier = Modifier.padding(top = 2.dp),
) {
Text(stringResource(R.string.comments_read_more))
Text(
stringResource(
if (expanded) R.string.comments_show_less else R.string.comments_read_more,
)
)
}
}
}
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,7 @@
<string name="comments_title">Comments</string>
<string name="comments_empty">No comments</string>
<string name="comments_read_more">Read more</string>
<string name="comments_show_less">Show less</string>
<string name="comments_like_count">Likes: %1$s</string>
<string name="comments_replies_failed">Couldn\'t load replies</string>
<string name="comments_load_failed">Couldn\'t load comments</string>
Expand Down