Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviewer 2 closed #224 on 2026-08-28 with a directive: split the work into four narrow PRs. This is Split PR 4 (configuration + operator policy) and addresses the P2 finding the reviewer assigned to it.
Two operator-facing docs contradicted the code that PR #330 landed.
Config::enforce_owner_pushdeclaresdefault_value_t = true,.env.examplesets=true, the README env-var table says "Defaults totrue", and the runtime behavior matches. ButSECURITY.mdline 57 (the "Repository write authorization defaults" section) andREADME.mdline 69 (the "Known limitations" prose) both still said the default wasfalse. The runtime, .env.example, env-var table, and security prose were lying to operators in opposite directions.What this PR changes
SECURITY.md— rewrite the owner-push limitation to lead with "defaults totrue" and describeGITLAWB_ENFORCE_OWNER_PUSH=falseas the explicit rolling-upgrade compatibility override.README.md— same correction in the Known-limitations bullet.crates/gitlawb-node/tests/owner_push_default_docs.rs— new regression test that reads the four surfaces at test time and asserts each independently says the default istrue. Reverting either doc edit or flippingdefault_value_tback tofalseturns a named test red.Boundaries covered
default_value_t = truedeclaration inConfigand the.env.exampleshipping default.Why this is its own PR (and not part of #224)
Reviewer 2: "Use the tested configuration default as the source of truth. State that owner enforcement is enabled by default and describe
GITLAWB_ENFORCE_OWNER_PUSH=falseonly as the explicit rolling-upgrade compatibility override. Consolidate the duplicate limitation sections." The reviewer called this out as the P2 finding for the policy split, not the post-receive or transport split. It does not need the outbox work, the ANS-104 work, or any of the cert/CLI changes to land.Overlap with open PRs
This PR is safe to land independently. It does not require any sibling PR. No new migration. No new dependency. No new env var. No code path change.
Verification
The regression test was load-bearing-checked before committing: stashing the SECURITY.md edit made
security_md_states_owner_push_default_is_truego red on the exact pre-fix prose; stashing the README edit madereadme_known_limitations_states_owner_push_default_is_truego red on the exact pre-fix prose. The other two tests (.env.examplerow and the existing env-var table) stayed green on each revert, confirming each surface is checked independently.Summary by CodeRabbit