You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gl: warn when Arweave manifest discovery fails on page 1 (silent Ok(vec![])) #603
recover_from_arweave in crates/gl/src/clone.rs treats the first GraphQL gateway failure (HTTP error, transport error, invalid JSON) like an empty discovery result: the loop breaks and returns Ok(vec![]) with no warning unless refs were already collected on a later page.
Motivation
Related failure class to #400 (silent empty vs degraded upstream). #438 fixed unwrap_or_default() on Err recovery paths; page-1 discovery silent degrade is unchanged pre-existing behavior (see comments ~689–698 in clone.rs).
Failure path
User runs gl clone with Arweave/IPFS recovery enabled.
First POST {gateway}/graphql fails (503, network error, bad JSON).
refs stays empty; function returns Ok(vec![]); clone::run exits 0 with no warning: arweave/ipfs gateway recovery failed: ….
Operators cannot distinguish “no manifest txs” from “gateway unreachable.”
Suggested fix
Distinguish failed first request from successful empty discovery (report/warn or surface to run per #400 warning style), while keeping intentional silent behavior for benign unconfigured gateways if product still wants that—document whichever contract you choose.
Regression test
Mock gateway 503 on page 1; assert warning (or Err) and that run does not present a clean success with zero paths when recovery was expected.
Notes
CodeRabbit flagged this on #438 as outside-diff; confirmed drift on #438 head (not introduced there). Track here for a follow-up PR.
Activity