Skip to content

test(gl): scrub GITLAWB_ALLOW_INSECURE_HTTP in doctor_transport_node harness #602

Open

Description

@jatmn

Context

PR #394 adds crates/gl/tests/doctor_transport_node.rs. doctor_with clears proxy-related env vars but does not env_remove("GITLAWB_ALLOW_INSECURE_HTTP").

Problem

If the parent shell exports GITLAWB_ALLOW_INSECURE_HTTP=1, subprocess gl doctor inherits it. Tests such as a_plaintext_remote_node_is_refused_like_the_helper_and_never_probed expect refusal without opt-in and can flake locally (CI is usually clean).

Suggested fix

In doctor_with, remove GITLAWB_ALLOW_INSECURE_HTTP before applying extra_env, so tests that need opt-in set it explicitly (several cases already pass it via extra_env).

Acceptance

  • cargo test -p gl --test doctor_transport_node passes with GITLAWB_ALLOW_INSECURE_HTTP=1 exported in the parent shell.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:testTest coverage or harnesssev:lowCosmetic, cleanup, or nice-to-have

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions