Skip to content

ipfs_pin::cat and gl mcp read bodies without a real bound #504

Closed as duplicate

Description

@PierrunoYT

Two more unbounded reads missed by the existing lists:

Fix: cap both with a shared bounded reader (see #418, #473), enforce the cap while streaming rather than from the header, and size the allocation from bytes actually received.

Found in the Oct 2 2026 audit (A14) at bfc44f9.

Activity

  1. added
    kind:securityVulnerability fix or hardening
    sev:highMajor break or real security/trust risk, no easy workaround
    subsystem:peersPeer announce, discovery, and registry
    crate:nodegitlawb-node — the serving node and REST API
    crate:glgl — the contributor CLI
    subsystem:storageBlob/object store, Arweave, IPFS, archives
    sev:mediumDegraded but workaround exists
    and removed
    sev:highMajor break or real security/trust risk, no easy workaround
    subsystem:peersPeer announce, discovery, and registry
    on Oct 2, 2026
  2. beardthelion commented on Nov 17, 2026

    @beardthelion
    Collaborator

    Both halves are tracked elsewhere. The gl mcp unbounded read is the client-side success-body class in #473. The ipfs_pin::cat read (ipfs_pin.rs:1552-1563) is the same site as #471 and #472 and part of the node's outbound response-bound class in #418. Closing in favor of those so each fix is reviewed once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    crate:glgl — the contributor CLIcrate:nodegitlawb-node — the serving node and REST APIkind:securityVulnerability fix or hardeningsev:mediumDegraded but workaround existssubsystem:storageBlob/object store, Arweave, IPFS, archives

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions