Skip to content

api: mutation handlers succeed on quarantined repos while push 404s #503

Closed

Description

@PierrunoYT

Push to a quarantined repo 404s, but the other mutation handlers do not check quarantine: merge/close PR (api/pulls.rs:191-200), visibility, branch protection, labels, webhooks and replicas all succeed on a quarantined repo.

Impact: defense-in-depth gap. The invariant is that a quarantined mirror is hidden as if it did not exist; callers can still mutate it and learn it exists from the response shape.

Fix: have the repo-lookup helpers these handlers share treat a quarantined repo as missing (404), and add a deny test per mutation. The read-side counterpart is the encrypted-blob and withheld-paths routes, filed separately.

Found in the Oct 2 2026 audit (A12) at bfc44f9.

Activity

  1. added
    kind:securityVulnerability fix or hardening
    sev:highMajor break or real security/trust risk, no easy workaround
    subsystem:apiNode REST API request/response surface
    crate:nodegitlawb-node — the serving node and REST API
    sev:mediumDegraded but workaround exists
    and removed
    sev:highMajor break or real security/trust risk, no easy workaround
    on Oct 2, 2026
  2. beardthelion commented on Nov 17, 2026

    @beardthelion
    Collaborator

    Fixed in #566. The mutation handlers named here (PR merge/close, issue close, protect, labels, webhooks, visibility) now go through the same quarantine-aware gate as reads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    crate:nodegitlawb-node — the serving node and REST APIkind:securityVulnerability fix or hardeningsev:mediumDegraded but workaround existssubsystem:apiNode REST API request/response surface

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions