You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
storage: encrypt_and_pin re-seals withheld blobs through unbounded sync reads with no permit or budget #486
encrypt_and_pin (crates/gitlawb-node/src/encrypted_pin.rs:119-189) re-seals every withheld blob in a loop, reading each object with the synchronous unbounded store::read_object (:155) directly on the async worker, with no batch budget, no pin_semaphore/encrypt_semaphore permit, and no per-request timeout on the Kubo upload. Its twin pin loops were hardened for exactly this (#173/#174: read_object_bounded, spawn_blocking, PIN_BATCH_BUDGET, permits); this loop predates or missed that pass. Reached from the detached post-push task (api/repos.rs:1468, :881-911); plan_seal re-seals on reader-set or tag changes, re-reading every withheld blob.
Impact
A repo owner flipping one reader DID on a repo with many withheld files makes the detached task block a tokio worker per object and flood Kubo with sequential uploads, for hours, with no aggregate bound. Owner-triggered (authenticated), hence not high.
This is the encrypt_and_pin site already described in the 2026-08-15 comment on #204: the bare store::read_object at encrypted_pin.rs:155 on the async worker. Tracking it there so the fix covers every blocking-git site in one place. The permit and batch-budget points from this issue are worth carrying over to #204.
Activity
beardthelion commentedon Nov 17, 2026
This is the
encrypt_and_pinsite already described in the 2026-08-15 comment on #204: the barestore::read_objectatencrypted_pin.rs:155on the async worker. Tracking it there so the fix covers every blocking-git site in one place. The permit and batch-budget points from this issue are worth carrying over to #204.