Skip to content

Aligned Node versions with the node24 runtime - #311

Merged
9larsons merged 2 commits into
mainfrom
slars/pin-node-24-runtime
Nov 16, 2026
Merged

9larsons merged 2 commits into
mainfrom
slars/pin-node-24-runtime

Conversation

@9larsons

@9larsons 9larsons commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Tests now run on Node 24 and 26. Lint, typecheck and the dist build in test.yml and sync-dist.yml move back from 26 to 24.

The action runs on GitHub's node24 runtime (runs.using: node24), the only one the runner offers for JavaScript actions. So:

  • Node 24 is what ships. The committed dist must be built and checked on it, and check-dist and sync-dist must use the same version so they agree.
  • Node 26 only matters for running the code, so it's added to the test job alone. It's there to catch problems before the runner offers a newer runtime. Lint, typecheck and the ncc build give the same result on either version.
  • Renovate now skips node major updates, which clears the blocked Node 26 .nvmrc update from the dashboard. Minor and patch updates continue.

Verified locally: tests pass on 24 and 26, and dist rebuilt on 24 matches the committed one.

GitHub's runner only executes JavaScript actions on node24, so action.yml
cannot move to Node 26. CI had been bumped to Node 26, testing and building
dist on a version the action never runs on, while .nvmrc stayed at 24 and
left Renovate's Node 26 update blocked by its closed PR.

CI now runs on Node 24 again and Renovate skips Node majors until the
runner supports a newer runtime.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The rebuild-dist, validate, and check-dist jobs now use Node.js 24. The test job runs on Node.js 24 and 26, with fail-fast disabled. Renovate now disables major updates for the node dependency and describes its version as matching the Actions runtime in action.yml.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

  • TryGhost/action-deploy-theme issue 53: The change updates workflow Node.js versions and prevents Renovate major updates for the node dependency. It addresses the Node.js entries in the tracker, but does not change .nvmrc or close the tracker item.

Suggested reviewers: aileen

Merge Risk: Minimal · up to d9f9d

This change aligns CI and the dist build with the Node 24 action runtime and stops Renovate from proposing Node major upgrades. It has no production runtime impact and is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title "Aligned Node versions with the node24 runtime" matches the main change. The PR sets CI jobs and the committed dist build to Node 24, and the Renovate rule keeps Node on the action's runtime…
Description check Passed The description states that tests now run on Node 24 and 26, and that lint, typecheck, and the dist build move from Node 26 back to Node 24 in test.yml and sync-dist.yml. It also says Renovate now ski…
Full details: Title check

Explanation

The title "Aligned Node versions with the node24 runtime" matches the main change. The PR sets CI jobs and the committed dist build to Node 24, and the Renovate rule keeps Node on the action's runtime. The title is specific and concise. It omits the Renovate change and the Node 26 test matrix, which is acceptable.

Full details: Description check

Explanation

The description states that tests now run on Node 24 and 26, and that lint, typecheck, and the dist build move from Node 26 back to Node 24 in test.yml and sync-dist.yml. It also says Renovate now skips node major updates. These points match the changed workflow files and renovate.json. The description is specific and on-topic, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 06008c67-e1f4-4a48-9b03-8c09f22348a6
Commits

Reviewing files that changed from the base of the PR and between 2b12c5a and d9f9dfa.

Files selected for processing: 1

  • .github/workflows/test.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Lint, typecheck and the dist build stay on Node 24, the version the action
ships on; tests also run on Node 26 so the action is ready when the runner
adds a newer runtime.
@9larsons 9larsons changed the title Pinned Node to the action's node24 runtime Aligned Node versions with the node24 runtime Nov 16, 2026
@9larsons
9larsons merged commit ec47ea4 into main Nov 16, 2026
9 checks passed
@9larsons
9larsons deleted the slars/pin-node-24-runtime branch November 16, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant