1197 fix version code inactive bundles - #1198
Conversation
0c7b5e6 to
313d6f0
Compare
- findMaxAppVersionCode no longer ignores inactive bundles/apks - instead of extracting the highest versionCode from all tracks, it now extracts the highest versionCode of all bundles and APKs Resolves Triple-T#1197
313d6f0 to
356609d
Compare
|
Reverted to DRAFT state. Looks like the fix doesn't solve my issue. The Google API still returns 18 as latest versionCode. I'll have to look at this again. |
| } | ||
| } | ||
|
|
||
| override fun findMaxAppVersionCode(editId: String): Int { |
There was a problem hiding this comment.
Why was this pulled out into a new fn? This module isn't supposed to have logic so this code should go back in DefaultEditManager.kt
There was a problem hiding this comment.
Ah, thanks for the feedback. I wasn't aware of this. The reason was simplicity: The new function's logic needs Bundles and APKs from the Android Publisher. Both of these aren't available in DefaultEditManager, yet, and I was reluctant to introduce two new dependencies there. But I totally get your point and would change it.
But - the fix didn't work anyway. It looks like Track.releases, Bundles.list and Apks.list all only contain active versions. So for now I don't see a way of fixing the issue when using the ResolutionStrategy.AUTO. Also since I manually set my versionCode yesterday to be able to release my app update, I can't reproduce the issue on my machine anymore.
2 participants
Fixes #1197