Fix failing bootstrapListing task - #1195
Conversation
Google disabled the deprecated endpoint https://developers.google.com/android-publisher/api-ref/rest/v3/inappproducts in favor of https://developers.google.com/android-publisher/api-ref/rest/v3/monetization.onetimeproducts. This broke the bootstrapListing task when it tried to retrieve the in-app products from the deprecated endpoint. Use the new one-time products endpoint. Resolves Triple-T#1174
https://developers.google.com/android-publisher/api-ref/rest/v3/monetization.onetimeproducts/patch fails with a 404 if trying to PATCH a non-existing one-time product if allowMissing is not true
|
|
||
| override fun updateInAppProduct(productFile: File): UpdateProductResponse { | ||
| override fun updateInAppProduct(productFile: File, regionsVersion: String): UpdateProductResponse { | ||
| println("updateInAppProduct($productFile)") |
There was a problem hiding this comment.
Let's print the the regionsVersion here and above and fix the empty strings.
There was a problem hiding this comment.
Thanks for your review and your fast response!
I applied your suggestions and just committed them. I figured for consistency you'd probably also want the SubscriptionMetadata being moved to Responses and did that.
I'm just unsure what you mean with "fix the empty strings".
There was a problem hiding this comment.
Oh nice, thanks.
I mean that {"regionsVersion":""} is invalid right? Like for tests it doesn't matter, but the API would reject the empty version? So let's put something real in there and check that it shows up in the Basic product publishes test.
There was a problem hiding this comment.
Got it! 😀
Just pushed the changes. (For subscriptions, too)
|
Sweet, thanks! |
2 participants
Google disabled the deprecated endpoint https://developers.google.com/android-publisher/api-ref/rest/v3/inappproducts in favor of https://developers.google.com/android-publisher/api-ref/rest/v3/monetization.onetimeproducts. This broke the bootstrapListing task when it tried to retrieve the in-app products from the deprecated endpoint.
Use the new one-time products endpoint.
Resolves #1174
P.S. I chose 4.2.0 as proposed new version. You could also consider using 5.0.0 because it is a breaking change - but on Google's side not on the plugin's side.