recursion exercises: refactor: simplify recursion logic in exercises 4 and 5 for learner clarity - #671
Merged
mao-sz merged 3 commits intoSep 8, 2026
Conversation
mao-sz
requested changes
Sep 8, 2026
mao-sz
left a comment
Contributor
There was a problem hiding this comment.
Thanks @damon314159 and for the detailed write-up. I agree on both fronts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
I believe the example solutions provided could do a better job at clearly demonstrating to learners the recursive steps, without additional syntax noise and overly complex logic. See the issue linked below for more detail.
Please note this is not me submitting my solutions as a learner, I am aware of and understand that rule.
This PR
Refactors the example solutions to both those exercises in the way described in my linked issue
All tests still pass
Issue
Closes #670
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder