Skip to content

fix(web): expose complete run input in the detail header - #1112

Open
wcy12378 wants to merge 1 commit into
Tencent:mainfrom
wcy12378:codex/run-input-disclosure
Open

wcy12378 wants to merge 1 commit into
Tencent:mainfrom
wcy12378:codex/run-input-disclosure

Conversation

@wcy12378

Copy link
Copy Markdown

Fixes #1101.

The run header clips its original input to one line without a way to read the rest. Keep the compact preview and add a native disclosure for the complete, escaped input. The expanded text preserves line breaks, wraps long values, and supports keyboard scrolling within a bounded region. Empty input retains the existing fallback.

Retain the disclosure node, reading position, and keyboard focus when live output or artifact changes rebuild the same run detail. Switching runs or changing input creates a fresh disclosure. This follows the existing frame-preservation pattern in the renderer.

Validation:

  • Node 24.15.0: node --check web/app/runs.js and node --test webtest/tests/run-input.test.mjs webtest/tests/runs-detail.test.mjs webtest/tests/runs-actions.test.mjs — 15 tests passed, 0 failed/skipped. Covers short, long, multiline, escaped, and empty input, plus live-output rebuilds retaining expanded state/scroll/focus and switching runs resetting the control.
  • The missing-disclosure and live-refresh regression assertions were observed failing before their respective fixes.
  • Playwright with installed Microsoft Edge: actual renderRunDetail DOM and repository stylesheets in a component fixture, at 1440px and 390px in light/dark themes. All four cases passed Enter-to-expand, complete original text, preserved line breaks, keyboard End scrolling, mouse collapse, and no horizontal overflow. No console/page errors.
  • py -X utf8 scripts/check-public.py and git diff --check passed. Independent review reran the three new input tests successfully.

Browser plugin not available; used existing Playwright/Edge without new dependencies. The browser fixture isolates run detail from navigation-frame handlers. Live SOP execution, full browser acceptance, and Go tests were not run; API/runtime behavior is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 运行详情页的需求描述被强制单行截断,既无展开入口也无悬停全文,超出部分永久不可见

1 participant