Skip to content

fix(web): separate node artifact card fields - #1111

Open
wcy12378 wants to merge 1 commit into
Tencent:mainfrom
wcy12378:codex/node-artifact-layout
Open

wcy12378 wants to merge 1 commit into
Tencent:mainfrom
wcy12378:codex/node-artifact-layout

Conversation

@wcy12378

Copy link
Copy Markdown

Fixes #1102.

Node artifact titles, paths, and metadata render as inline siblings, so short values run together and long values force the card wider than its column. Make the text container a shrinkable vertical flex layout: title, path, and metadata each get their own line. Keep the file icon and preview affordance from shrinking, and retain ellipsis for long titles and paths.

Only web/observability.css changes. The existing buttons, artifact IDs, preview handlers, and keyboard behavior remain unchanged.

Validation:

  • Node 24.15.0: node --test webtest/tests/runs-detail.test.mjs webtest/tests/runs-actions.test.mjs — 12 tests passed, 0 failed/skipped, on both baseline and candidate.
  • Playwright with installed Microsoft Edge: rendered the actual renderRunDetail DOM from the repository's mocked run fixture and all repository stylesheets in a component page. Checked 1440px and 390px viewports in light and dark themes, using short and long titles/paths. All four cases show three distinct lines and no card overflow; no console/page errors. Keyboard focus on the artifact button remains visible.
  • Before the fix the same fixture joined the fields and expanded its cards to about 1207px. The corrected cards fit their columns at about 331px on desktop and 270px on the narrow viewport.
  • py -X utf8 scripts/check-public.py and git diff --check passed.

Browser plugin not available; used existing Playwright and Edge without adding dependencies. The browser fixture isolates the rendered run detail from navigation-frame handlers. Live SOP execution, artifact preview delivery, full browser acceptance, and Go tests were not run for this stylesheet-only change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 节点交付物卡片里名称与路径挤在同一行首尾相连,缺少分隔与换行

1 participant