Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #951, addressing its optional Compose concurrency setting. Execution-slot wait telemetry remains in #956; project admission and fairness scheduling are outside this change.
The platform binary already accepts
-worker-concurrency, but Compose only passes the workspace path. Operators therefore have to replace the whole service command to tune sandbox execution slots.Pass
${AGENTFLOW_WORKER_CONCURRENCY:-8}as the existing flag's value, add the setting to.env.example, and document its scope and how to apply it. The default remains 8, including installations whose existing.envhas no new setting. The exec-form command preserves the workspace argument and passes the limit as one argument.Validation:
docker compose --env-file .env.example --profile platform config --format jsonrendered the expected complete platform argv for unset, empty,3, and12environment overrides..env.examplewith the new setting omitted also rendered-worker-concurrency 8, verifying existing installation compatibility.cmd/agentflow/main.goandinternal/runtime/sandbox_manager.go: the flag defaults to 8 and supplies the manager's shared execution-slot channel.py -X utf8 scripts/check-public.pyandgit diff --checkpassed.No services were started or recreated. Go tests, a live multi-run workload, and browser acceptance were not run; this change only wires the existing flag into Compose and documents it.