Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1086.
The conversation process pool forwarded stdout/stderr but dropped process start, start failure, and exit events. As a result, assistant diagnostics could report
not_startedalongside hundreds of output lines and omit the exit code. Runner JSON transport also changes integer map values to floating-point values, so strict Go type assertions lost PID, exit-code, and CPU metadata.Forward the three lifecycle events through the existing bounded queue, clearing
process.started.Messagebefore enqueueing so command arguments and prompts stay private. Read numeric metadata from native integers, ordinary JSON, andUseNumberJSON. After cancellation, drain only remaining lifecycle evidence within the existing bounded stop context; do not replay protocol output. Preserve a final event batch when stdin failure races the final poll. Execution outcomes and the event wire shape are unchanged.Validation: Go 1.26.11, Linux amd64, CGO disabled. Test binaries ran in a Linux container with their respective package directories as working directories.
Full repository tests, browser acceptance, live providers, and live remote runners were not run. Native Windows package compilation has existing Unix syscall dependencies, so tests used Linux. Execution hosts must run the updated runtime to forward the lifecycle evidence; older runners retain their existing behavior.