Repository navigation
Conversation
wcy12378
force-pushed
the
codex/terminal-diagnostic
branch
from
November 19, 2026 15:41
73de907 to
1594daf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1085.
A successful terminal submission deliberately cancels the model process. The assistant accepts the reply, but its CLI attempt records that cleanup as
cancelled / context canceled.Bind each reply-producing CLI invocation to its terminal tool session. Diagnostics treat cancellation as completion only when that exact session committed a terminal result, and record
cli.terminal_committedas the reason. Other failures, external cancellation, timeouts, earlier/later attempts, and concurrent approval-review attempts retain their own outcomes. The execution error and orchestration behavior are unchanged. Chat, bot replies, and report invocations pass their owning session; approval and helper invocations do not.Validation: Go 1.26.11, Linux amd64, CGO disabled, test binary executed in a Linux container with the package directory as its working directory.
Status:cancelled Error:context canceled./could not resolve fixture/source paths; rerunning with the package working directory passed.npm --prefix chatbot run buildpassed on the rebased source. The 48-test suite and related vet were rerun on base6f606cfafter preserving its model selection and prompt assembly changes.Full repository tests, browser acceptance, and live provider tests were not run. Native Windows compilation of httpapi has existing Unix syscall dependencies; validation used the Linux target.