Repository navigation
fix(cli): accept cooperation context for debug rule mutations - #781
Open
Shizuku-in wants to merge 2 commits into
Open
Shizuku-in wants to merge 2 commits into
Shizuku-in wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CLI rejected
--contextand--observationfordebug rule_add,rule_disable,rule_enable, andrule_removebecause its dispatch check only allowedreplayto carry those flags. Omitting them caused shared-tab cooperation checks to reject the request, leaving CLI users unable to manage interception or mock rules.Fix
Use
DebugAction::cooperation_guarded()in the CLI, matching the MCP implementation. All four rule mutations now accept the IDs returned bysync. Unguarded debug actions continue to reject these flags.Verification
Before the fix, the regression test failed on
rule_addwithinvalid_params. It now verifies that all four commands forward the suppliedcontext_idandobservation_idto a mock daemon over IPC.All 9
target_control_cliintegration tests passed:cargo test --locked -p bsk --test integration target_control_cli::