Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording can stall for 10 seconds when Chrome reports a tab as complete while the initial
tabs.get()is still in flight and that call subsequently resolves with a stale loading snapshot. Subscribe to the completion event before reading the snapshot, so either current state or the event can complete the wait.The browser regression now captures bounded stdout and stderr from
bsk record startand reports an early process exit. Its existing timing assertions are preserved.The race was found while investigating the recording check on #777. The available CI log does not establish that this race caused that failure. Related #670 addresses a separate CLI/daemon timeout.
Testing
pnpm ext:test: 4,103 passed, 8 skipped. Extension type checking, lint, build, and bilingual changelog validation also passed.chrome.action.openPopup(). Linux end-to-end verification remains open.