Skip to content

fix(record): avoid missing tab readiness events - #779

Open
Kidz0419 wants to merge 1 commit into
Tencent:mainfrom
Kidz0419:codex/recording-readiness-diagnostics
Open

Kidz0419 wants to merge 1 commit into
Tencent:mainfrom
Kidz0419:codex/recording-readiness-diagnostics

Conversation

@Kidz0419

Copy link
Copy Markdown

Recording can stall for 10 seconds when Chrome reports a tab as complete while the initial tabs.get() is still in flight and that call subsequently resolves with a stale loading snapshot. Subscribe to the completion event before reading the snapshot, so either current state or the event can complete the wait.

The browser regression now captures bounded stdout and stderr from bsk record start and reports an early process exit. Its existing timing assertions are preserved.

The race was found while investigating the recording check on #777. The available CI log does not establish that this race caused that failure. Related #670 addresses a separate CLI/daemon timeout.

Testing

  • Added a focused regression that reproduces the full 10-second delay on the old code and starts recording without that delay with the fix.
  • pnpm ext:test: 4,103 passed, 8 skipped. Extension type checking, lint, build, and bilingual changelog validation also passed.
  • The full browser regression could not reach recording on macOS. Chrome for Testing 158.0.8127.36 matched the CI browser version, but the local pairing fixture failed at chrome.action.openPopup(). Linux end-to-end verification remains open.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant