Repository navigation
feat(cli): read fill values from stdin - #563
Open
Wang-Zephyr wants to merge 2 commits into
Open
Wang-Zephyr wants to merge 2 commits into
Wang-Zephyr wants to merge 2 commits into
Conversation
Wang-Zephyr
marked this pull request as ready for review
November 3, 2026 15:40
Author
|
Merged current main (88ca431) in 54f15f2 and resolved the CLI context/test-directory conflicts. The fill stdin path keeps the new ClientContext and optional-session behavior. Verified against this merged tree: 719 CLI unit tests passed (2 ignored), 46 CLI parsing tests passed, 13 usage-error tests passed, and all 5 interaction-preferences CLI/daemon tests passed, including stdin and inline values. cargo fmt and both skill packaging checks passed. GitHub now reports the branch mergeable. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
bsk fill --value-stdinso callers can supply a fill value without putting it in the CLI's process arguments. Input is read as UTF-8 until EOF, preserving empty input, whitespace, CRLF and trailing newlines. Existing--valuecalls keep their behavior.Exactly one value source is required. Input and target validation happen before daemon startup.
--value-stdinrejectsBSK_CANCEL_ON_STDIN_CLOSE=1, since that setting reserves stdin as a parent cancellation pipe.Addresses #544's
fill --value-stdinalternative.Validation
c134fbbbecause--value-stdinis unknownPassed locally on Windows:
cargo fmt --all -- --checkcargo test -p bsk --lib --test cli_parse --test cli_usage_errors --test interaction_preferences --locked(579 passed, 2 ignored)cargo test -p bsk-protocol --locked(181 passed)node scripts/check-crate-skill.mjsnode scripts/check-skill-bundles.mjsnode --test scripts/check-skill-bundles.test.mjs(6 passed)vitest run --maxWorkers=2(3,604 passed, 418 skipped)Platform limitations, checked against the same base:
file_transfer.rs,ipc.rs, andskill_install/harness.rs.pnpm lintpasses formatting, CSS and plugin type checks, then fails six existing plugin assertions that expect POSIX/tmp/...paths; base has the same six failures.cargo test --workspace --lockedpasses the CLI library tests, then stops inauto_update_handover: this host's Windows Job does not allow detached-daemon breakaway. The same manual-update failure reproduces on base. Linux/full CI validation is still needed.