Repository navigation
Harden developer script downloads and local tool resolution - #4
Merged
Merged
Conversation
|
joey-huckabee
marked this pull request as ready for review
November 11, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Developer scripts now fail when locked local esbuild is missing instead of reaching npm/npx download or lifecycle fallback. Geodata downloads restrict both initial and redirect protocols to HTTPS and fail on HTTP errors. Existing bundle/watch arguments, upstream URLs, output paths and Cargo commands are preserved.
This addresses the seven script vulnerabilities triaged in
docs/evals/2026-11-11-sonar-triage.md: S6505 keysAaHGAPksOB7cC4l45FHK,AaHGAPmGOB7cC4l45FHQ; S6506 keysAaHGAPmCOB7cC4l45FHL,AaHGAPmCOB7cC4l45FHM,AaHGAPmCOB7cC4l45FHN,AaHGAPmCOB7cC4l45FHO,AaHGAPmCOB7cC4l45FHP.Failure behavior deliberately changes: missing/non-executable local tooling exits before Cargo/watch with an install instruction; HTTP 4xx/5xx or a redirect to HTTP stops the download script with a nonzero curl status. No checksum, retry, atomic replacement or mutable-upstream integrity guarantee is added.
Validation on head 446e143, base 287f155:
All 23 optional baseline smells remain deferred. No Sonar settings, issue states, credentials or manual analysis were touched. PR #3 independently handles basemap diagnostics: ordinary network failures were already contained by allSettled and silently swallowed; the renderer loader rejection handler is defensive. The separate public/read-only NONE-gate investigation and proposed setup/proof plan remain documented without changes.
Draft for independent exact-head/diff review; coordinator owns any normal merge.
Reviewer follow-up: curl options are defined once in a Bash array; the five calls preserve exact flags, URLs, destinations and ordering. All eight focused tests remain unchanged and pass. Final-head Linux CI run 42975981459 passed the full gate (21 Rust tests; 52 Node tests; zero skips; both real-server integrations). Automatic SonarCloud passed; the public unresolved PR issue query reports zero findings. No suppressions or settings changes.