fix: add Angular to DB framework selector - #1290
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe database library metadata now lists Angular as a supported framework. ChangesDatabase library framework support
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Angular will appear in the framework selector through a narrow metadata update, with no merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds Angular to TanStack DB's framework metadata so it appears in the docs framework selector. Angular users can now select the adapter from the same dropdown as React, Vue, Solid, Svelte, and Vanilla.
Root Cause
The DB docs sidebar and the site-wide framework selector use separate data sources. The DB repository's docs config already includes Angular, but the
tanstack.comlibrary metadata omitted it, soFrameworkSelectfiltered Angular out of the dropdown.Approach
Add
angularto the existingdb.frameworkslist. The shared framework registry already supplies Angular's label, value, and logo, so no selector or asset changes are needed.Key Invariants
Non-goals
Trade-offs
This keeps the existing explicit per-library metadata model. Deriving the selector from docs navigation would couple two currently separate systems and is unnecessary for this fix.
Verification
pnpm testResult: 525 tests passed and 3 environment-dependent tests skipped. TypeScript and lint checks passed; lint retains one pre-existing warning in
src/utils/repo-path.ts.Files changed
src/libraries/libraries.ts— declare Angular as a supported TanStack DB framework.Summary by CodeRabbit