Skip to content

fix: add Angular to DB framework selector - #1290

Merged
AlemTuzlak merged 1 commit into
TanStack:mainfrom
KyleAMathews:fix/db-angular-framework-selector
Sep 22, 2026
Merged

AlemTuzlak merged 1 commit into
TanStack:mainfrom
KyleAMathews:fix/db-angular-framework-selector

Conversation

@KyleAMathews

@KyleAMathews KyleAMathews commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds Angular to TanStack DB's framework metadata so it appears in the docs framework selector. Angular users can now select the adapter from the same dropdown as React, Vue, Solid, Svelte, and Vanilla.

Root Cause

The DB docs sidebar and the site-wide framework selector use separate data sources. The DB repository's docs config already includes Angular, but the tanstack.com library metadata omitted it, so FrameworkSelect filtered Angular out of the dropdown.

Approach

Add angular to the existing db.frameworks list. The shared framework registry already supplies Angular's label, value, and logo, so no selector or asset changes are needed.

Key Invariants

  • The selector continues to show only frameworks declared by TanStack DB.
  • Angular uses the existing shared framework metadata and icon.
  • Existing framework order and behavior remain unchanged.

Non-goals

  • No changes to the DB repository's docs navigation.
  • No changes to shared selector behavior or framework preference persistence.

Trade-offs

This keeps the existing explicit per-library metadata model. Deriving the selector from docs navigation would couple two currently separate systems and is unnecessary for this fix.

Verification

pnpm test

Result: 525 tests passed and 3 environment-dependent tests skipped. TypeScript and lint checks passed; lint retains one pre-existing warning in src/utils/repo-path.ts.

Files changed

  • src/libraries/libraries.ts — declare Angular as a supported TanStack DB framework.

Summary by CodeRabbit

  • New Features
    • Added Angular as a supported framework for the database library.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 93e0ae74-3de4-4765-8849-d154b4bb5bea

📥 Commits

Reviewing files that changed from the base of the PR and between a9c6ee7 and 76b3946.

📒 Files selected for processing (1)
  • src/libraries/libraries.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The database library metadata now lists Angular as a supported framework.

Changes

Database library framework support

Layer / File(s) Summary
Add Angular to the framework list
src/libraries/libraries.ts
The db library entry adds 'angular' to its frameworks array.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley

Merge Risk: ⚪ Minimal · up to 76b39

Angular will appear in the framework selector through a narrow metadata update, with no merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding Angular to the TanStack DB framework selector metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AlemTuzlak
AlemTuzlak merged commit 4a9ef75 into TanStack:main Sep 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants