Skip to content

fix(docs): Allow bracket notation in repo paths #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 1 commit into from
Sep 21, 2026
Merged

fix(docs): Allow bracket notation in repo paths #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/repo-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export const MAX_REPO_PATH_LENGTH = 512

const REPO_PATH_SEGMENT_PATTERN = /^[a-zA-Z0-9._$+-]+$/
const REPO_PATH_SEGMENT_PATTERN = /^[a-zA-Z0-9._$+\[\]-]+$/

Check warning on line 3 in src/utils/repo-path.ts

View workflow job for this annotation

GitHub Actions / PR

eslint(no-useless-escape) 

Unnecessary escape character '['

export function isValidRepoPath(path: string) {
if (path === '') {
Expand Down
6 changes: 6 additions & 0 deletions tests/repo-path.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ assert.equal(
'underscores remain valid repo path segments',
)

assert.equal(
isValidRepoPath('examples/svelte/ssr/src/routes/[postId]/+page.ts'),
true,
'Svelte bracket-notation route params are valid repo path segments',
)

assert.equal(
isValidRepoPath('../src/routes/__root.tsx'),
false,
Expand Down
Loading