Repository navigation
Preview: divider reaches both frame edges; Original / Split / Processed modes - #158
Draft
StuartCameronCode wants to merge 1 commit into
Draft
StuartCameronCode wants to merge 1 commit into
StuartCameronCode wants to merge 1 commit into
Conversation
…rocessed modes The comparison's divider was clamped to 5-95% of the panel, so the left and right 5% always showed the same side: 36 px on a 720-wide frame, wider than a typical left crop (forum feedback, videohelp thread 419911). It now spans 0-1, with the line and handle drawn inset at the edges. A view mode (ComparisonViewMode: Original / Split / Processed) shows either frame whole. It lives in MainViewModel.previewViewMode, so it survives scrubber moves and new previews, and is picked from a pill at the top of the preview or with B / S / P (bare keys, so text fields keep them). Each mode draws only its side at its own aspect (#149), and 1:1 measures the frame on screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forum feedback (videohelp thread 419911): the preview's divider couldn't reach the far left or right, so judging a left crop was guesswork.
Why
BeforeAfterComparisonWidgetclamped the divider to 5–95% of the panel. The left and right 5% therefore always showed the same frame: 36 px on a 720-wide source, wider than a typical left crop (Detect borders suggestedleft: 14on the reporter's clip).Change
ComparisonViewMode). Pick one from a pill at the top of the preview, or with B / S / P.AppShortcutentries without modifiers, so they don't fire while you're typing in a text field.MainViewModel.previewViewMode, so it stays when you move the scrubber, a new preview arrives or you switch videos.beforeAspectRatioand Processed atafterAspectRatio, keeping the Preview window #149 aspect rules.The optional crop-rectangle guide is left out.
Tests
before_after_comparison_test.dart:app_shortcut_test.dart: B / S / P are wired, aren't taken from a focused text field, and don't clash with other shortcuts.preview_aspect_test.dart: the view-model wiring.flutter test --exclude-tags heavy,gpu: 1476 passed, 7 skipped.Known minor issue
When the histogram is open on a preview narrower than about 680 px, its card covers the right end of the mode pill. The P shortcut still works. Offsetting the histogram card down while it's open would fix it.
🤖 Generated with Claude Code