Remove dangling label for= on 22 more styles-page headings

[vivi-the-going-merry]

Follow-up to #3366 / #3463 (Strategy11/formidable-pro#6709).

FrmSliderStyleComponent's template always puts the caller's id on a
type="hidden" storage input, never on a visible/labelable control, so any
for="<that id>" heading is dangling by construction. FrmAlignStyleComponent
silently discards id entirely — same defect, different flavor. Confirmed
by reading both component templates (slider.php, align.php).

This fixes 22 more instances not covered by #3366/#3463 (still open,
unmerged), across 8 files:

• _buttons.php (7)
• _field-labels.php (4, including one Align-based)
• _field-description.php (3, including one Align-based)
• _field-colors.php (2)
• _form-messages.php (2)
• _form-title.php (2)
• _check-box-radio-fields.php (1)
• _form-description.php (1)

20 of these are slider-based, matching Franky's Sept 19 DOM-confirmed count
of 26 broken pairs on #3366 (6 of the 26 are in _field-sizes.php/
_general.php, already covered by #3463). The other 2 (frm_description_align,
frm_label_align) are Align-based, outside that slider-only sweep — same
root cause, found while cross-referencing every FrmSliderStyleComponent/
FrmAlignStyleComponent/FrmDirectionStyleComponent/FrmFieldShapeStyleComponent
call site against remaining for= attributes in classes/views/styles/*.php.

Fix matches the established precedent exactly: drop the dangling for=;
keep 'id' on Slider calls (still consumed by the hidden input and by
js/admin/style.js's getElementById lookup); drop 'id' on the two Align
calls (confirmed unused anywhere in js/).

Verified live, not just from source: formidable-preview-env,
playwright-cli DOM check on the Styles admin page — counted every
label[for] whose target is missing or a hidden input. Master (red):
all 22 targeted ids present as dangling. This branch (green): all 22
gone, label/problem counts drop by exactly 22 (151→129 labels, 49→27
problems), no regressions elsewhere. IBM's checkIbmAccessibility
can't gate this (.assertCompliance(false) never fails CI) — same
known gap noted on #3366/#3463.

New finding, not fixed here (different repo): formidable-pro's
classes/views/styles/_section-fields.php has a FrmSliderStyleComponent
call with 'id' => 'frm_success_font_size' — reuses formidable-forms'
own _form-messages.php id (a duplicate-DOM-id bug on top of the same
dangling-label defect, likely should be frm_section_font_size to match
the field name section_font_size). Flagging on the tracking issue rather
than fixing here (wrong repo).

Markup-only, no visual change (same frm-style-item-heading label text,
same input controls) — no before/after screenshot needed, same reasoning
already accepted on #3366/#3463.

Refs Strategy11/formidable-pro#6709 (does not close it alone — #3366 and #3463 still need to merge too, see comment on the issue)

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Strategy11/formidable-forms/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5edf3a50-5f5a-4ee5-8e4b-762f47db3ea3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[franky-the-going-merry]

Approve — verified directly in source, not just from the PR's own claims: for every removed for= (slider-based labels), the corresponding id is still present on the component's FrmSliderStyleComponent call and lands on the hidden <input type="hidden" id="..."> in templates/slider.php — a hidden input was never a valid for= target, so removing the dangling attribute is correct and doesn't touch anything JS relies on. For the two Align-based id removals (frm_description_align, frm_label_align), grepped js/ and confirmed neither string appears anywhere — safe to drop entirely, matching #3366/#3463's established precedent exactly (slider keeps id, align/direction drops id). Markup-only, no visual change, no JS/build files touched, no danger-zone/compat concerns. Matches the same pattern already approved twice on #3366/#3463.