Skip to content

Fix removeField's delete assertion to check a real field id #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivi-the-going-merry wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix removeField's delete assertion to check a real field id #3464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f601e5a
Fix removeField's delete assertion to check a real field id
vivi-the-going-merry[bot] Sep 23, 2026
6cb466a
Fix removeField's within() to scope off the captured element, not a r…
vivi-the-going-merry[bot] Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 37 additions & 26 deletions tests/cypress/e2e/Forms/fieldsInFormBuilder-crud.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,36 +50,47 @@ describe( 'Fields in the form builder', () => {
};

const removeField = field => {
field.within( () => {
// Same .frm-show-hover opacity gate as the toggle above - reveal it first.
// Same #wpbody-content 1280x0 race as createAndDuplicateField above
// (formidable-forms#3399) - .scrollIntoView() first reliably clears it.
cy.get( '.frm-field-action-icons' )
.invoke( 'css', 'opacity', 1 )
.find( '.dropdown .frm-hover-icon .frmsvg' )
.first()
.scrollIntoView()
.should( 'be.visible' )
.click();
// data-type holds the field's type slug (e.g. "text"), shared by the original and its
// duplicate - not unique enough to prove *this* field is gone. data-fid is the field's
// own database id, so capture it before deleting to assert against afterward.
// Read via .then($field => ...) and scope every command to that jQuery element with
// cy.wrap() - re-deriving commands from the stored `field` chainable a second time here
// (after other fields' own removeField() calls have queued commands in between) doesn't
// reliably yield this field's own element.
field.then( $field => {
const fid = $field.attr( 'data-fid' );

cy.wrap( $field ).within( () => {
// Same .frm-show-hover opacity gate as the toggle above - reveal it first.
// Same #wpbody-content 1280x0 race as createAndDuplicateField above
// (formidable-forms#3399) - .scrollIntoView() first reliably clears it.
cy.get( '.frm-field-action-icons' )
.invoke( 'css', 'opacity', 1 )
.find( '.dropdown .frm-hover-icon .frmsvg' )
.first()
.scrollIntoView()
.should( 'be.visible' )
.click();

// The menu is open via the click above (not hover-gated), so wait for the item to
// be visible instead of forcing through the open transition.
cy.get( '.frm-dropdown-menu .frm_delete_field' )
.should( 'be.visible' )
.and( 'contain', 'Delete' )
.click();
} );

// The menu is open via the click above (not hover-gated), so wait for the item to
// be visible instead of forcing through the open transition.
cy.get( '.frm-dropdown-menu .frm_delete_field' )
// Plain cy.get() by id (an id is unique) rather than cy.get().contains() - the latter
// can resolve to a narrower descendant node than the clickable link itself, which is
// what forced force here. Plain cy.get() on this id works unforced elsewhere in the
// suite.
cy.get( '#frm-confirmed-click' )
.should( 'be.visible' )
.and( 'contain', 'Delete' )
.and( 'contain', 'Confirm' )
.click();
} );

// Plain cy.get() by id (an id is unique) rather than cy.get().contains() - the latter
// can resolve to a narrower descendant node than the clickable link itself, which is
// what forced force here. Plain cy.get() on this id works unforced elsewhere in the
// suite.
cy.get( '#frm-confirmed-click' )
.should( 'be.visible' )
.and( 'contain', 'Confirm' )
.click();

cy.get( `li[data-type="${ field }"]` ).should( 'not.exist' );
cy.get( `li[data-fid="${ fid }"]` ).should( 'not.exist' );
} );
};

cy.contains( '#the-list tr', 'Test Form' ).trigger( 'mouseover' ).then( $row => {
Expand Down
Loading