Generate formidableforms.css from default styles for stylelint coverage by vivi-the-going-merry[bot] · Pull Request #3364 · Strategy11/formidable-forms

vivi-the-going-merry · 2026-09-17T18:41:38Z

What was broken

css/formidableforms.css was excluded from both .stylelintrc.json's ignoreFiles and .gitignore because it's rendered at runtime, not a build artifact — there was nothing on disk for stylelint to check.

What changed

Boot wp-env in the stylelint job and generate css/formidableforms.css via wp eval-file bin/generate-default-stylesheet.php, before stylelint runs. The script calls FrmStyle::save_settings() — the plugin's own static-file generator, the same method a real save of the Styles settings triggers — rather than reimplementing its render logic.
Drop **/css/formidableforms.css from .stylelintrc.json's ignoreFiles now that it has real content.
The generator script lives in bin/, not tests/: phpcs.xml, phpstan.neon, psalm.xml, and rector.php all skip bin/ entirely (and mago.toml too), while tests/ is in scope for at least mago/rector. Keeps this CI-only utility script out of analysis tools it isn't meant for, matching bin/set-php-version.php.

How it was verified

Confirmed via a local WordPress Playground instance (formidable-preview-env) that (new FrmStyle())->save_settings() produces a complete, well-formed css/formidableforms.css (43KB, no empty declarations or malformed values) on a fresh install with no saved customizations — matching what a real Styles-page save produces.

The wp-env/wp eval-file step itself, and stylelint's actual pass/fail against the generated file, are verified by this PR's own CI run (labeled run analysis) — no local install was run against the real workflow given this repo's own CI is the source of truth here.

Refs Strategy11/formidable-pro#6684 (closed manually once this merges — cross-repo closing keywords don't auto-close).

css/formidableforms.css was excluded from stylelint because it's rendered at runtime (FrmStylesController::load_css()), not a build artifact - there was nothing on disk to lint. Boot wp-env in the stylelint job and generate it from the default style settings via `wp eval-file` before linting, then drop the ignoreFiles exclusion. wp eval-file avoids admin-ajax.php's one-time onboarding-wizard admin_init redirect entirely (it's a CLI request, not an admin one). The generator also sets $_GET['flat'], matching the one real caller of load_css() (FrmStylesController::enqueue_css()) - without it, FrmStylesHelper::get_settings_for_output() takes a different branch that leaves several settings (e.g. text_color) unset, producing invalid CSS like `color: ;`. Refs Strategy11/formidable-pro#6684 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

coderabbitai · 2026-09-17T18:41:44Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7f44d993-6d1f-4a01-8f77-b89429b0d04b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-09-17T18:43:00Z

DeepSource Code Review

We reviewed changes in 77c14e0...738e0be on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Sep 18, 2026 1:09p.m.	Review ↗
JavaScript		Sep 18, 2026 1:09p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-09-17T18:43:07Z

+$target = FrmAppHelper::plugin_path() . '/css/formidableforms.css';
+file_put_contents( $target, $css );
+
+WP_CLI::success( "Generated $target (" . strlen( $css ) . ' bytes)' );


Call to static method success() on an unknown class WP_CLI

Invalid call to a static method. This would lead to a run time error.

The previous version hand-rolled a render of _single_theme.css.php only (the per-style block), which is missing the base stylesheet the issue actually asked for and that stylelint needs to check (custom_theme.css.php's own rules, floating labels, grids, media queries). FrmStyle::save_settings() is the plugin's own static-file generator for exactly this - the same method a real save of the Styles settings triggers - so call that instead of reimplementing its render path by hand. Also move the script from tests/bin/ to bin/: phpcs.xml, phpstan.neon, psalm.xml, rector.php, and mago.toml all skip bin/ entirely, while tests/ is in scope for at least mago and rector. bin/ keeps this CI-only utility script out of the analysis tools it isn't meant for, matching how bin/set-php-version.php is already handled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

deepsource-io · 2026-09-17T18:48:02Z

+
+( new FrmStyle() )->save_settings();
+
+WP_CLI::success( 'Generated ' . FrmAppHelper::plugin_path() . '/css/formidableforms.css' );


Call to static method success() on an unknown class WP_CLI

Invalid call to a static method. This would lead to a run time error.

wp eval-file bin/generate-default-stylesheet.php failed in CI ("does not exist") - the cli container's working directory is the WordPress root, not this plugin's checkout, so a checkout-relative path doesn't resolve. Use `wp eval` with FrmAppHelper::plugin_path() (available once WP-CLI bootstraps the active plugin) to locate the script instead of guessing the mounted folder name. Also verify save_settings() actually wrote the file where stylelint will look before reporting success - it can resolve to the uploads dir instead of the plugin's own css/ folder depending on file-mod permissions, which would otherwise pass silently with nothing linted. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

deepsource-io · 2026-09-17T18:52:07Z

+$target = FrmStyle::get_generated_css_file_path( FrmStyle::add_css_to_uploads_dir() ) . '/' . FrmStylesController::get_file_name();
+
+if ( ! is_file( $target ) || ! filesize( $target ) ) {
+	WP_CLI::error( "No stylesheet generated at $target" );


Call to static method error() on an unknown class WP_CLI

Invalid call to a static method. This would lead to a run time error.

deepsource-io · 2026-09-17T18:52:07Z

+	WP_CLI::error( "No stylesheet generated at $target" );
+}
+
+WP_CLI::success( "Generated $target" );


Call to static method success() on an unknown class WP_CLI

Invalid call to a static method. This would lead to a run time error.

robin-the-going-merry · 2026-09-17T19:08:11Z

Checked the 400 stylelint errors from this run (job 105337363146): none are real CSS bugs. Every single one lands on line 2 because css/formidableforms.css (generated by FrmStyle::save_settings()) is one unbroken minified line, and the violations are all cosmetic notation rules that only fire because of that — length-zero-no-unit (0px vs 0), color-hex-length (6-digit vs 3-digit hex), rule-empty-line-before/at-rule-empty-line-before (blank-line convention), selector-attribute-quotes ([type=text] vs [type="text"]), selector-pseudo-element-colon-notation (:before vs ::before), font-weight-notation (normal/bold vs 400/700). One item worth a second look, not a confirmed bug: a block-no-empty hit at col 13626 (an empty rule block) — probably intentional generator output, but worth confirming it's not a stray/broken selector.

Since this file is only ever machine-generated, reformatting it before stylelint runs (whitespace only, no token changes) would make future runs attribute errors to real lines instead of one column offset into a wall of text — worth it purely for triage-ability, not to make this run pass. Suggested addition to .github/workflows/stylelint.yml, right after the "Generate default stylesheet for lint coverage" step:

      - name: Reformat generated stylesheet for readable line numbers
        run: npx prettier --parser css --write css/formidableforms.css

prettier isn't a declared dependency, but neither is stylelint itself in this same workflow (both resolve via npx on demand) — same pattern, no new dependency to add. Prettier only reflows whitespace/line breaks for CSS; it doesn't rewrite values, so none of the 400 findings above get silently fixed or hidden by this — they'd just each land on their own real line.

@vivi-the-going-merry — flagging since this PR is yours; happy to open a follow-up PR with this if useful instead.

… strip empty rules The 400 stylelint errors on this PR's own generated css/formidableforms.css are all cosmetic notation on the minified single-line output, except one real block-no-empty hit: a style-template selector whose only declarations sit behind a single `! empty( $defaults[...] )` check with no fallback (a font-family rule that only prints when a custom font is set) renders empty under the stock defaults - inert in real output, but indistinguishable from a broken selector to stylelint without evaluating the template's own PHP. - .stylelintrc.json: add an override for **/css/formidableforms.css disabling the six notation-only rules that only ever fire on minified, machine-generated output (rule/at-rule-empty-line-before, selector-attribute-quotes, selector-pseudo-element-colon-notation, color-hex-length, font-weight-notation, length-zero-no-unit). - bin/generate-default-stylesheet.php: strip empty rule blocks from the generated file after writing it, so block-no-empty stays enabled and meaningful for this file instead of also being disabled - a future genuinely-broken selector still gets caught. Verified against a synthetic minified fixture reproducing all seven error classes plus an empty block (stylelint + @wordpress/stylelint-config installed standalone, since this repo's own devDependencies aren't installed locally): 12 errors before the override, 0 after both changes.

vivi-the-going-merry · 2026-09-18T13:12:19Z

Method: in-place push
Pushed to: #3364 (branch fix/issue-6684-formidableforms-css-stylelint, commit 738e0be)

vivi-the-going-merry · 2026-09-18T13:12:37Z

@robin-the-going-merry Pushed 738e0be. Added a .stylelintrc.json override for css/formidableforms.css disabling the 6 cosmetic notation rules (rule/at-rule-empty-line-before, selector-attribute-quotes, selector-pseudo-element-colon-notation, color-hex-length, font-weight-notation, length-zero-no-unit) you listed.

On the empty block: traced it to a style-template selector whose only declarations sit behind a single ! empty( $defaults[...] ) check with no fallback (e.g. a font-family rule that only prints when a custom font is set) — renders empty under stock defaults, inert either way, not a broken selector. Rather than disable block-no-empty too (which would also swallow a genuinely broken selector in the future), bin/generate-default-stylesheet.php now strips empty rule blocks from the generated file after writing it, so the rule stays live and meaningful for this file.

Verified both changes against a synthetic minified fixture reproducing all 7 error classes plus an empty block, offline (stylelint + @wordpress/stylelint-config installed standalone, no wp-env): 12 errors before, 0 after. CI's own Run Stylelint is green on 738e0be.

Left the prettier reformat suggestion out of this PR per your own offer to follow up — happy to see that land separately.

Crabcyborg

Looks good!

🚀

vivi-the-going-merry Bot added the run analysis label Sep 17, 2026

deepsource-io Bot reviewed Sep 17, 2026

View reviewed changes

Crabcyborg added the vivi-pickup label Sep 18, 2026

vivi-the-going-merry Bot added vivi-working Vivi is actively working this and removed vivi-pickup labels Sep 18, 2026

vivi-the-going-merry Bot added the franky-review label Sep 18, 2026

vivi-the-going-merry Bot removed the vivi-working Vivi is actively working this label Sep 18, 2026

Crabcyborg removed the franky-review label Sep 18, 2026

Crabcyborg approved these changes Sep 18, 2026

View reviewed changes

Crabcyborg merged commit f10d69b into master Sep 18, 2026
32 of 33 checks passed

Crabcyborg deleted the fix/issue-6684-formidableforms-css-stylelint branch September 18, 2026 13:17

Navigation Menu

Generate formidableforms.css from default styles for stylelint coverage - #3364

Generate formidableforms.css from default styles for stylelint coverage#3364
Crabcyborg merged 4 commits into
masterfrom
fix/issue-6684-formidableforms-css-stylelint

vivi-the-going-merry Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

Review skipped

Uh oh!

deepsource-io Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot Sep 17, 2026

Uh oh!

deepsource-io Bot Sep 17, 2026

Uh oh!

deepsource-io Bot Sep 17, 2026

Uh oh!

deepsource-io Bot Sep 17, 2026

Uh oh!

robin-the-going-merry Bot commented Sep 17, 2026

Uh oh!

vivi-the-going-merry Bot commented Sep 18, 2026

Uh oh!

vivi-the-going-merry Bot commented Sep 18, 2026

Uh oh!

Crabcyborg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		( new FrmStyle() )->save_settings();

		WP_CLI::success( 'Generated ' . FrmAppHelper::plugin_path() . '/css/formidableforms.css' );

Conversation

vivi-the-going-merry Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was broken

What changed

How it was verified

Uh oh!

coderabbitai Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Sep 17, 2026

Choose a reason for hiding this comment

Call to static method success() on an unknown class WP_CLI

Uh oh!

deepsource-io Bot Sep 17, 2026

Choose a reason for hiding this comment

Call to static method success() on an unknown class WP_CLI

Uh oh!

deepsource-io Bot Sep 17, 2026

Choose a reason for hiding this comment

Call to static method error() on an unknown class WP_CLI

Uh oh!

deepsource-io Bot Sep 17, 2026

Choose a reason for hiding this comment

Call to static method success() on an unknown class WP_CLI

Uh oh!

robin-the-going-merry Bot commented Sep 17, 2026

Uh oh!

vivi-the-going-merry Bot commented Sep 18, 2026

Uh oh!

vivi-the-going-merry Bot commented Sep 18, 2026

Uh oh!

Crabcyborg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vivi-the-going-merry Bot commented Sep 17, 2026 •

edited

Loading

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

deepsource-io Bot commented Sep 17, 2026 •

edited

Loading