Skip to content

Remove Add-On request link to connect.formidableforms.com - #3344

Open
stephywells wants to merge 2 commits into
masterfrom
remove-connect-formidableforms-addon-link
Open

stephywells wants to merge 2 commits into
masterfrom
remove-connect-formidableforms-addon-link

Conversation

@stephywells

@stephywells stephywells commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

The Add-Ons page had a link called "Request Add-On." It sent users to connect.formidableforms.com. That site is going away, so this link had to go too.

This PR removes the link in two places:

  • The small text at the bottom of the Add-Ons list: "Not finding what you need? Request Add-On."
  • The button that shows up when a search finds no add-ons.

It also removes the code that built that link's web address, since nothing uses it anymore.

Test plan

  • Open the Add-Ons page in WP Admin. Check that the old "Request Add-On" text and link at the bottom are gone.
  • Search for an add-on that does not exist. Check that the "No add-ons found" message shows, but no button appears under it.
  • Run the Cypress test for the Add-Ons page and confirm it passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Changes

    • Removed the “Request Add-On” link and button from the add-ons page.
    • When no add-ons match the selected filters or search, the page now displays only the empty-state message.
    • Add-on category filtering and count displays remain unchanged.
  • Tests

    • Updated add-ons page checks to verify that the request option is hidden in empty states.

That site is being phased out. Drops the footer link on the Add-Ons
page and the empty-state button that both pointed to it, along with
the now-unused addonRequestURL wiring and its Cypress coverage.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: db63c413-3546-4e7d-8a71-03afcd0cd503

📥 Commits

Reviewing files that changed from the base of the PR and between 2a2d8c1 and 1daffc6.

📒 Files selected for processing (7)
  • classes/controllers/FrmAddonsController.php
  • classes/views/addons/index.php
  • classes/views/addons/list.php
  • js/addons-page.js
  • js/src/addons-page/constants.js
  • js/src/addons-page/ui/showEmptyState.js
  • tests/cypress/e2e/Add-Ons/validateAddOnsPage.cy.js
💤 Files with no reviewable changes (3)
  • classes/views/addons/index.php
  • js/src/addons-page/constants.js
  • classes/views/addons/list.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The add-on request URL and request link are removed from the controller, views, frontend empty state, and Cypress tests. Existing add-on category expansion and count rendering remain unchanged.

Changes

Add-on request removal

Layer / File(s) Summary
Controller and view cleanup
classes/controllers/FrmAddonsController.php, classes/views/addons/*
The controller no longer defines or passes the request URL. The views no longer document or render the request link.
Frontend empty-state update
js/src/addons-page/constants.js, js/src/addons-page/ui/showEmptyState.js, js/addons-page.js, tests/cypress/e2e/Add-Ons/validateAddOnsPage.cy.js
The empty state hides the request button and shows only the empty-state container. Tests now verify that the button is hidden. Category expansion and count rendering remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: crabcyborg

Merge Risk: ⚪ Minimal · up to 1daff

The discontinued add-on request entry points are removed consistently across the controller, views, frontend, bundle, and tests, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 35 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the Add-On request link to connect.formidableforms.com.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 3
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch remove-connect-formidableforms-addon-link
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-connect-formidableforms-addon-link

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 16, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 2a2d8c1...de5c181 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Sep 16, 2026 7:33p.m. Review ↗
JavaScript Sep 16, 2026 7:33p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

…idableforms-addon-link

# Conflicts:
#	js/addons-page.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant