fix render for subject change - #227
Open
SharonStrats wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated code introduces a strict-null-checks TypeScript type error (passing possibly-undefined subject to fetchContentAndMetadata) and should be corrected before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR fixes the Source pane not displaying content after the subject changes by re-triggering content/metadata loading on context/subject updates and guarding against stale async responses overwriting newer state.
Changes:
- Reload content/metadata when
contextorsubjectchanges (moved fromfirstUpdatedtoupdated). - Reset
dataLoadedwhen inputs change so the editor card is re-rendered after the new load completes. - Add a warning log when loading fails.
File summaries
| File | Description |
|---|---|
| src/components/source-provider/SourceProvider.ts | Reworks lifecycle to reload on subject/context changes and avoid stale async updates; adds warning logging on load failure. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: bourgeoa <2218470+bourgeoa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something happened where when a subject changed it was loading the content for the new subject and nothing was getting displayed.