remove edit icon for unsupported panes - #757
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, localized to rendering logic, and consistently gates the Edit UI on paneSupportsEditing without introducing functional risk.
Pull request overview
This PR updates the file explorer header controls to hide the Edit (pencil) action entirely when the currently selected pane does not support editing, aligning the UI with actual capabilities.
Changes:
- Removes the “Not Supported” edit tooltip path and stops rendering the Edit button when
paneSupportsEditingis false. - Simplifies the Edit button’s disabled state to depend only on access (
canEdit) when editing is supported.
File summaries
| File | Description |
|---|---|
| src/components/file-explorer-header/FileExplorerHeaderControls.ts | Conditionally renders the Edit button only for panes that support editing, instead of showing a disabled control. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…@5.0.0-1 pane-registry@5.0.0-0 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.