Tighten TypeScript syntax checks - #639
Open
andrewiggins wants to merge 4 commits into
Open
Conversation
Contributor
|
We detected some changes in public packages, and there are no updates in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This makes TypeScript stricter across the repository. It now catches unused labels, TypeScript syntax that needs runtime transformation, and imports that should only be used for types.
The settings live in one shared configuration used by every package and the kitchen sink example. Existing polyfill syntax that does not meet the new rules has narrow exceptions and TODOs so it can be cleaned up separately without weakening checks elsewhere.
Testing
pnpm lintpnpm exec tsc --build --pretty --forcepnpm buildpnpm run test --coverage— 174 tests passedpnpm exec playwright test— 13 tests passed