Repository navigation
Conversation
StepInfo.from_step looked up RAW_REWARD_GLOBAL at the top level of the step info, but BrowserEnv puts task info under info["task_info"]. raw_reward was always None and summary_info["cum_raw_reward"] was always 0, even for MiniWoB tasks that report a raw reward.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StepInfo.from_steplooked upRAW_REWARD_GLOBALat the top level of the step info, butBrowserEnvputs task info underinfo["task_info"]. Soraw_rewardwas alwaysNoneandsummary_info["cum_raw_reward"]was always 0, even on MiniWoB tasks that report a raw reward.One-line fix, plus two asserts in
test_run_exp(raw_reward == 1andcum_raw_reward == 1onminiwob.click-test). They fail on main and pass here.