Repository navigation
Keep the / shortcut out of dialogs and let people turn it off - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the two global shortcuts, Ctrl+K and /, with a real keyboard. Ctrl+K worked. Fixes for /: it pulled focus to the catalog search behind an open dialog (it now does nothing while a dialog is open, with Ctrl or Cmd held, during IME composition or in editable fields; AltGr still works); a single-character shortcut must be switchable (WCAG 2.1.4), so settings gain a Shortcuts row with Press / to search, on by default, and the search placeholder drops the slash hint when it is off. Ctrl+K now waits for the catalog search box to exist instead of a fixed 30 ms timer and selects its text. Five new tests, three fail without the change. Not checked: other keyboard layouts and Cmd+K on a Mac, a real screen reader.