Repository navigation
Make the run dialog usable by keyboard and screen reader - #21
Merged
Merged
Conversation
… buttons on screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the install/update/repair run dialog with a real keyboard and a simulated API (plan, running with download progress, failed, finished, restart needed). Fixes: focus fell to the page when the start button and then Stop disappeared (it now goes to the dialog heading); progress was never announced (new aria-live line per step and a final result); the download bar had no name (now Firefox: 40%); at the 980x620 minimum window the failed state with the log open was 27px taller than the window and pushed Close and Retry off screen (the overlay row is now definite so the log shrinks). Contrast was audited in all three states, six styles and two themes with no failures. Two new tests fail without the change. Not checked: a real screen reader, a real install, Stop during a real run.