Repository navigation
Keep keyboard focus in the storage section after cleaning - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the storage cleanup confirmation with a real keyboard: opens with focus on Cancel, Tab and Shift+Tab stay inside, Escape and Cancel close without cleaning and return focus, confirm cleans once. Found one problem: the button that opened the confirmation is disabled while cleaning, so focus fell to the page top. Now, if focus was lost, it moves to the result (or to the section heading when the clean fails). Two tests cover both cases and fail without the change. Checked with a simulated API, so nothing was deleted; not checked with a real screen reader.