fix: bound Claude subagent startup and daemon MCP requests - #728
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f64b45e994
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 060d518c41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b114f3b150
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94fb411586
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Pushed CI unblock
Backup on ScriptedAlchemy: |
|
Retrigger CI on 47143c8; reopening immediately. |
47143c8 to
8d99714
Compare
8d99714 to
bd2d2f9
Compare
f191a79
into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopened
Summary
SubagentStartresolve only local workspace boundaries, avoid direct global-registry access, and fail open within 1.5 secondsproject_paththrough the daemon, consuming the selector before project-local tool dispatchRoot cause
SubagentStartperformed a daemon status RPC through the global project resolver. A connectable but saturated daemon could wait forever in the response-line liveness loop because it had no total deadline. Same-route project opens also bypassed the existing writer-contention grace period, allowing a warm-up queued behind the daemon writer gate to hold clients indefinitely.A stale registry entry for the user-profile root could also start a watcher and project freshness work across the entire profile. That work could hold the daemon-wide writer coordinator and starve unrelated project MCP calls. MCP sessions inherited the broad launch directory even when a tool supplied an explicit project path. Unscoped CLI tools additionally wrapped their cwd fallback as an explicit project, producing a misleading disconnect instead of a projectless error.
Safety
Timeouts cancel handler futures and never retry requests automatically. Mutating-tool timeout errors state that the outcome may be unknown. Project warm-up continues detached and returns the existing retryable warming error. No database or index fallback was added. Ambient registry rows are preserved but ignored by implicit routing and background services. Explicit CLI and MCP project selectors keep their existing behavior.
Tests
cargo checkand focused unit/integration suites passRepository-wide clippy and cargo test currently expose unrelated failures already reproducible on the untouched base branch.