Skip to content

chore: use renamed sbomify/sbomify-action - #331

Open
renatgalimov wants to merge 2 commits into
masterfrom
chore/rename-sbomify-action
Open

renatgalimov wants to merge 2 commits into
masterfrom
chore/rename-sbomify-action

Conversation

@renatgalimov

@renatgalimov renatgalimov commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

sbomify/github-action was renamed to sbomify/sbomify-action. The SBOM step now runs the action's image ghcr.io/sbomify/sbomify-action pinned by digest to release 26.11.0, instead of a branch ref: the action's action.yml runs the mutable :latest image, so neither @master nor a commit-SHA pin fixes what executes. Same docker://…@sha256 form as Screenly and Qt-Snap.

Tested: actionlint clean; the pinned image run locally with this step's env on Cargo.lock (upload/augment off) produced cli.cdx.json. The upload itself runs only on the next v* tag.

Diagram

PR #331 diagram

Copilot AI lite review requested due to automatic review settings October 30, 2026 06:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The SBOM workflow uses a mutable third-party @master action with SBOMIFY_TOKEN and id-token: write, allowing upstream changes to alter release-time execution unless it is pinned immutably.

1 open issue

Review effort: Lite

Comment thread .github/workflows/sbom.yml Resolved
The action's action.yml runs ghcr.io/sbomify/sbomify-action:latest,
so a branch or commit-SHA ref still executes whatever image :latest
points to. Reference the 26.11.0 image digest directly, as Screenly
and Qt-Snap already do.
Copilot AI lite review requested due to automatic review settings November 12, 2026 19:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The workflow changes execution to a pinned third-party container while retaining secret-upload and OIDC permissions, and the offline review cannot validate its upload, augmentation, or OIDC behavior.

No open issues 🎉

1 resolved since last review

Review effort: Lite

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants