Skip to content

chore: remove redirect stubs for migrated Edge Apps - #900

Merged
salmanfarisvp merged 5 commits into
masterfrom
chore/remove-migrated-app-stubs
Nov 19, 2026
Merged

salmanfarisvp merged 5 commits into
masterfrom
chore/remove-migrated-app-stubs

Conversation

@salmanfarisvp

@salmanfarisvp salmanfarisvp commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Remove the 26 edge-apps/<app>/ redirect stubs (a README plus an old icon) for apps that now live in their own repos. No current app manifest references them; every manifest now uses edge-apps/icons/.
  • Keep icons/, helpers/ (TfL bus stop lookup, RSS Reader news icons) and the apps still in this repo (Instagram, Queue Management System, Sonar Dashboard).
  • Rewrite edge-apps/README.md to describe what's left in the directory and how to add an app icon.
  • Drop stale .prettierignore entries and update the edge-apps note in .claude/CLAUDE.md.

Notes

  • Older published app versions may still reference the removed edge-apps/<app>/static/... icon URLs.
  • Old links to tree/master/edge-apps/<app> will 404 instead of showing a redirect README.

- Remove 25 stub directories for apps that moved to their own repos
- Keep welcome-app until its manifest uses the shared icon
- Drop stale .prettierignore entries
- Update edge-apps/README.md and CLAUDE.md
@github-actions

Copy link
Copy Markdown

Failed to generate code suggestions for PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The README still contains inaccurate manifest guidance and omits the retained welcome-app compatibility content, leaving two active documentation issues unresolved.

2 open issues
What changed in this PR

Removes obsolete redirect stubs and legacy icons for Edge Apps that have migrated to standalone repositories, while retaining shared assets and apps still maintained in this repository.

Changes:

  • Deletes migrated apps’ README stubs and old per-app icon assets.
  • Rewrites edge-apps/README.md with the remaining directory structure and shared-icon guidance.
  • Removes stale Prettier exclusions and updates repository guidance in .claude/CLAUDE.md.
File Description
edge-apps/​weather/​static/​img/​icon.svg Removes the migrated Weather app icon.
edge-apps/​weather/​README.md Removes the Weather redirect stub.
edge-apps/​tfl-bus-status/​static/​images/​icon.svg Removes the migrated TfL Bus Status app icon.
edge-apps/​tfl-bus-status/​README.md Removes the TfL Bus Status redirect stub.
edge-apps/​strava-club-leaderboard/​static/​images/​icon.svg Removes the migrated Strava Club Leaderboard icon.
edge-apps/​strava-club-leaderboard/​README.md Removes the Strava Club Leaderboard redirect stub.
edge-apps/​simple-timer/​static/​img/​icon.svg Removes the migrated Simple Timer icon.
edge-apps/​simple-timer/​README.md Removes the Simple Timer redirect stub.
edge-apps/​simple-table-app/​static/​images/​icon.svg Removes the migrated Simple Table app icon.
edge-apps/​simple-table-app/​README.md Removes the Simple Table app redirect stub.
edge-apps/​simple-message-app/​static/​img/​icon.svg Removes the migrated Simple Message app icon.
edge-apps/​simple-message-app/​README.md Removes the Simple Message app redirect stub.
edge-apps/​rss-reader/​README.md Removes the RSS Reader redirect stub while retaining its helper assets.
edge-apps/​README.md Documents the remaining Edge Apps directory contents and shared icon workflow.
edge-apps/​qr-code/​static/​img/​icon.svg Removes the migrated QR Code app icon.
edge-apps/​qr-code/​README.md Removes the QR Code redirect stub.
edge-apps/​powerbi/​static/​img/​icon.svg Removes the migrated Power BI icon.
edge-apps/​powerbi/​README.md Removes the Power BI redirect stub.
edge-apps/​powerbi-legacy/​README.md Removes the Power BI Legacy redirect stub.
edge-apps/​outlook-calendar/​README.md Removes the Outlook Calendar redirect stub.
edge-apps/​menu-board/​static/​img/​icon.svg Removes the migrated Menu Board icon.
edge-apps/​menu-board/​README.md Removes the Menu Board redirect stub.
edge-apps/​iframe/​static/​images/​icon.svg Removes the migrated iframe app icon.
edge-apps/​iframe/​README.md Removes the iframe app redirect stub.
edge-apps/​grafana/​static/​img/​icon.svg Removes the migrated Grafana icon.
edge-apps/​grafana/​README.md Removes the Grafana redirect stub.
edge-apps/​google-calendar/​README.md Removes the Google Calendar redirect stub.
edge-apps/​flying-toasters/​README.md Removes the Flying Toasters redirect stub.
edge-apps/​demo-dashboard/​README.md Removes the Demo Dashboard redirect stub.
edge-apps/​countdown-timer/​static/​img/​icon.svg Removes the migrated Countdown Timer icon.
edge-apps/​countdown-timer/​README.md Removes the Countdown Timer redirect stub.
edge-apps/​clock/​static/​img/​icon.svg Removes the migrated Clock icon.
edge-apps/​clock/​README.md Removes the Clock redirect stub.
edge-apps/​charlie-hr-app/​static/​img/​icon.svg Removes the migrated CharlieHR app icon.
edge-apps/​charlie-hr-app/​README.md Removes the CharlieHR app redirect stub.
edge-apps/​cap-alerting/​README.md Removes the CAP Alerting redirect stub.
edge-apps/​calendar/​README.md Removes the Calendar redirect stub.
edge-apps/​bamboo-hr-app/​static/​images/​icon.svg Removes the migrated BambooHR app icon.
edge-apps/​bamboo-hr-app/​README.md Removes the BambooHR app redirect stub.
edge-apps/​asset-metadata/​static/​images/​icon.svg Removes the migrated Asset Metadata app icon.
edge-apps/​asset-metadata/​README.md Removes the Asset Metadata redirect stub.
edge-apps/​3d-text/​static/​img/​icon.svg Removes the migrated 3D Text app icon.
edge-apps/​3d-text/​README.md Removes the 3D Text redirect stub.
.prettierignore Removes formatting exclusions for deleted app directories.
.claude/​CLAUDE.md Updates repository guidance to reflect the reduced Edge Apps directory.

Review effort: Lite

Comment thread edge-apps/README.md Resolved
Comment thread edge-apps/README.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the changes consistently remove obsolete migrated-app stubs and icons while documenting the retained assets and repository guidance.

No open issues 🎉

2 resolved since last review

Review effort: Lite

@salmanfarisvp
salmanfarisvp marked this pull request as ready for review November 19, 2026 10:49
@github-actions

Copy link
Copy Markdown

Failed to generate code suggestions for PR

- The Welcome app manifest now uses edge-apps/icons/welcome-app.svg
Copilot AI lite review requested due to automatic review settings November 19, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change has an active moderate issue because it removes the required welcome-app compatibility stub while the app remains referenced elsewhere and undocumented in the migrated-app inventory.

1 open issue

Review effort: Lite

Comment thread edge-apps/README.md Resolved
Copilot AI lite review requested due to automatic review settings November 19, 2026 10:54
@salmanfarisvp
salmanfarisvp requested a review from 514sid November 19, 2026 10:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change removes publicly hosted icon paths and redirects that older app versions may still request, so compatibility and rollback expectations require release-owner confirmation.

No open issues 🎉

1 resolved since last review

Review effort: Lite

@salmanfarisvp
salmanfarisvp merged commit d3aca3c into master Nov 19, 2026
5 checks passed
@salmanfarisvp
salmanfarisvp deleted the chore/remove-migrated-app-stubs branch November 19, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants