Fix assertion handler signatures - #587
Merged
Merged
Conversation
CI leaves custom handlers disabled, hiding their signature mismatch. Enable them in Debug and Release for tests and both examples; this coverage intentionally fails until the signature fix is applied.
With custom assertions enabled, the supplied long parameter leaves SQLiteCpp's int overload undefined and causes link errors. Match the public declaration in examples, tests, and documentation.
Record the custom-handler link fix and its CI coverage under PR #587.
|
coverage: 99.714%. remained the same — fix-assertion-handler-signatures into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the supplied assertion handlers to SQLiteCpp's
intline parameter, fixing link errors when custom assertions are enabled. Add Debug and Release CI coverage for the unit tests and both examples.Validation: the handler-enabled builds fail before the fix and pass afterward.