Conversation
SRombauts
force-pushed
the
fix-transaction-rollback-cleanup
branch
from
September 23, 2026 14:07
9c92dd0 to
2778666
Compare
|
coverage: 99.714%. remained the same — fix-transaction-rollback-cleanup into master |
SRombauts
force-pushed
the
fix-transaction-rollback-cleanup
branch
from
September 24, 2026 06:42
2778666 to
ea95fc6
Compare
SRombauts
marked this pull request as draft
September 24, 2026 07:33
SRombauts
commented
Sep 24, 2026
| } | ||
| const int ret = mDatabase.tryExec("ROLLBACK TRANSACTION"); | ||
| (void)ret; // Avoid an unused-variable warning when assertions are disabled. | ||
| SQLITECPP_ASSERT(SQLITE_OK == ret, mDatabase.getErrorMsg()); |
Owner
Author
There was a problem hiding this comment.
I am not too comfortable with introducing more SQLITECPP_ASSERT() into the codebase.
I'll consider a dedicated mechanism to report errors so that the application can properly handle them
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollback()tryExec()in the destructor and report rollback failures throughSQLITECPP_ASSERTTransactiondoes not affect a later transaction on the same connectionThe private state remains one
bool, so this does not change the class layout.