Skip to content

Remove deprecated Savepoint::rollback() #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SRombauts merged 1 commit into from
Sep 23, 2026
+5 −3
Merged

Remove deprecated Savepoint::rollback() #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Update googletest to v1.18.0 (#583)
- Improve tests for `Savepoint::rollbackTo()` and scope-exit rollback semantics (#584)

### Removed

- Remove the deprecated `Savepoint::rollback()` alias; use `rollbackTo()` instead (#585)

## [3.4.0] - 2026-09-21

### Added
Expand Down
2 changes: 0 additions & 2 deletions include/SQLiteCpp/Savepoint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ class SQLITECPP_API Savepoint
* @brief Rollback to the savepoint, but don't release it.
*/
void rollbackTo();
// @deprecated same as rollbackTo();
void rollback() { rollbackTo(); }

private:
Database& mDatabase; ///< Reference to the SQLite Database Connection
Expand Down
2 changes: 1 addition & 1 deletion tests/Savepoint_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ TEST(Savepoint, releaseAndRollback)

// Releasing or rolling back an already released savepoint throws.
EXPECT_THROW(savepoint.release(), SQLite::Exception);
EXPECT_THROW(savepoint.rollback(), SQLite::Exception);
EXPECT_THROW(savepoint.rollbackTo(), SQLite::Exception);
}

// Automatic rollback if release() is not called before the end of scope.
Expand Down
Loading