fix(postgres): randomize test username and update grant tests - #5990
Merged
cmgoffena13 merged 2 commits intoAug 29, 2026
Conversation
4 tasks
Collaborator
|
@sakshipatil-hue -- formatting is failing. I pulled the fork and confirmed |
Signed-off-by: sakshipatil-hue <sakshipatil8674788@gmail.com>
sakshipatil-hue
force-pushed
the
fix-postgres-grants-clean
branch
from
August 29, 2026 19:33
1557673 to
58947c2
Compare
Contributor
Author
|
Hi @cmgoffena13, thanks for the feedback! I've gone ahead and formatted the target file using Ruff. The branch is updated and ready for your review whenever you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_grants_plan_target_layer_physical_onlyandtest_grants_plan_target_layer_virtual_onlyto utilize dynamic usernames via f-strings rather than hardcoded strings.Test Plan
test_integration_postgres.py.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO